Skip to content

[GLUTEN-12053][CELEBORN] Bump Celeborn version to 0.6.3#12057

Merged
wForget merged 1 commit into
apache:mainfrom
SteNicholas:GLUTEN-12053
May 11, 2026
Merged

[GLUTEN-12053][CELEBORN] Bump Celeborn version to 0.6.3#12057
wForget merged 1 commit into
apache:mainfrom
SteNicholas:GLUTEN-12053

Conversation

@SteNicholas
Copy link
Copy Markdown
Member

@SteNicholas SteNicholas commented May 9, 2026

What changes are proposed in this pull request?

Bump Celeborn version to 0.6.3. Backport:

Fixes: #12053.

How was this patch tested?

CI.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions Bot added CORE works for Gluten Core BUILD INFRA TOOLS labels May 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Run Gluten Clickhouse CI on x86

@SteNicholas SteNicholas marked this pull request as draft May 9, 2026 05:17
@github-actions github-actions Bot added the RSS label May 10, 2026
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@SteNicholas SteNicholas marked this pull request as ready for review May 10, 2026 04:53
@SteNicholas
Copy link
Copy Markdown
Member Author

Ping @jackylee-ch, @kerwin-zk.

.getClass()
.getDeclaredMethod("prepareForMergeData", Integer.TYPE, Integer.TYPE, Integer.TYPE);
prepareMethod.invoke(shuffleClient, shuffleId, mapId, attemptId);
} catch (NoSuchMethodException ignored) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a warning for this?

Copy link
Copy Markdown
Member Author

@SteNicholas SteNicholas May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackylee-ch, it's unnecessary to log warning for this. This interface is removed from 0.6.3. In addtion, other method invokers also do not log warning for NoSuchMethodException.

"mapperEnd", Integer.TYPE, Integer.TYPE, Integer.TYPE, Integer.TYPE);
mapperEndMethod.invoke(shuffleClient, shuffleId, mapId, attemptId, numMappers);
}
} catch (NoSuchMethodException ignored) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@SteNicholas SteNicholas requested a review from jackylee-ch May 11, 2026 01:38
@jackylee-ch
Copy link
Copy Markdown
Contributor

The ClickHouse CI failed with SPARK-33084: Add jar support Ivy URI in SQL, which actually download other maven jar failed and it is not related to current pr.

Copy link
Copy Markdown
Contributor

@jackylee-ch jackylee-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
}

public static void prepareForMergeData(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should cache reflection methods to avoid creating them on every call.

Copy link
Copy Markdown
Member Author

@SteNicholas SteNicholas May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wForget, this improvement would be implemented in another pull request.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wForget, this improvement would be implemented in another pull request.

Could you create an issue to track this first?

@SteNicholas SteNicholas requested a review from wForget May 11, 2026 05:14
Copy link
Copy Markdown
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SteNicholas

@wForget wForget merged commit 7e04fae into apache:main May 11, 2026
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CELEBORN] Bump Celeborn to 0.6.3

4 participants